Messages in this thread | | | Date | Thu, 10 Nov 2011 09:56:56 +0800 | From | ANNIE LI <> | Subject | Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture |
| |
On 2011-11-10 0:22, Ian Campbell wrote: > IMHO the gnttab_ bit belongs in either (or both) the struct name or the > variable names referencing the struct, rather than the fields > themselves. It should be obvious from the context that this member is > something to do with gnttab. e.g. I think gnttab_shared->addr would be > fine, as would shared->addr in the context of gnttab.c etc. Right. Thanks you all for the review, I will improve patches based on those suggestions and resend them.
Thanks Annie
| |