Messages in this thread | | | Date | Wed, 9 Nov 2011 10:20:13 -0500 | From | Vivek Goyal <> | Subject | Re: [PATCH] kdump: kill redundant code |
| |
On Wed, Nov 09, 2011 at 03:04:52PM +0800, Dave Young wrote: > in while loop below, hole_end > crashk_res.end is impossible: > while (hole_end <= crashk_res.end) { > [snip] > } > Killing the check code here > > Signed-off-by: Dave Young <dyoung@redhat.com>
Makes sense.
Acked-by: Vivek Goyal <vgoyal@redhat.com>
Vivek
> --- > kernel/kexec.c | 2 -- > 1 file changed, 2 deletions(-) > > --- linux-2.6.orig/kernel/kexec.c 2011-11-01 13:06:20.000000000 +0800 > +++ linux-2.6/kernel/kexec.c 2011-11-09 14:57:17.487022644 +0800 > @@ -500,8 +500,6 @@ static struct page *kimage_alloc_crash_c > > if (hole_end > KEXEC_CRASH_CONTROL_MEMORY_LIMIT) > break; > - if (hole_end > crashk_res.end) > - break; > /* See if I overlap any of the segments */ > for (i = 0; i < image->nr_segments; i++) { > unsigned long mstart, mend;
| |