lkml.org 
[lkml]   [2011]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver
    On 08/11/11 21:49, Nikolaus Voss wrote:

    > This driver has the following properties compared to the old driver:
    > 1. Support for multiple interfaces.
    > 2. Interrupt driven I/O as opposed to polling/busy waiting.
    > 3. Support for _one_ repeated start (Sr) condition, which is enough
    > for most real-world applications including all SMBus transfer types.
    > (The hardware does not support issuing arbitrary Sr conditions on the
    > bus.)
    >
    > Tested on Atmel G45 with BQ20Z80 battery SMBus client.
    >
    > Signed-off-by: Nikolaus Voss <n.voss@weinmann.de>

    <snip>

    > + dev->clk = clk_get(&pdev->dev, "twi_clk");
    > + if (IS_ERR(dev->clk)) {
    > + dev_err(&pdev->dev, "no clock defined\n");
    > + rc = -ENODEV;
    > + goto err_free_mem;
    > + }
    > + clk_enable(dev->clk);


    There are now dummy clk_prepare/unprepare functions in
    include/linux/clk.h, so you should be using them in this driver to
    future proof it.

    ~Ryan


    \
     
     \ /
      Last update: 2011-11-09 01:01    [W:0.021 / U:31.200 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site