Messages in this thread | | | Date | Tue, 8 Nov 2011 18:54:10 +0100 | From | "Roedel, Joerg" <> | Subject | Re: [PATCH] pci: More PRI/PASID cleanup |
| |
On Tue, Nov 08, 2011 at 10:31:58AM -0700, Alex Williamson wrote: > On Tue, 2011-11-08 at 18:17 +0100, Roedel, Joerg wrote: > > On Tue, Nov 08, 2011 at 09:44:30AM -0700, Alex Williamson wrote: > > > > > bit 0 (PCI_PASID_ENABLE) is reserved in the CAP register... > > > > Is it? Which spec are you using? In my version it is not reserved but > > states if it is supported to set the enable-bit. > > Latest I can find is the March 31, 2011 PASID ECN, which just lists that > bit as reserved.
Okay, my one is older and there it is stated as I implemented it. I will check with reality first before changing the code...
> I can drop it if need be, was just trying to do some cleanup on the > consistency of pci_reg.h before adding a bunch more defines to help > bounds checking and parsing for vfio-pci. Unless my spec is outdated, > it seems like there's more than an aesthetic change here though, so > resolving the conflicts with your latest work might be warranted.
Fine with me. The best is probably when I carry this change forward (when Jesse is ok with that) and put my changes on-top of that.
Thanks,
Joerg
-- AMD Operating System Research Center
Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632
| |