lkml.org 
[lkml]   [2011]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V3 2/4] drivers/i2c/busses/i2c-at91.c: add new driver
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    On 11/08/2011 03:41 PM, Felipe Balbi :

    >> + if (cpu_is_at91rm9200()) { /* AT91RM9200 Errata #22 */
    >
    > I don't think you should be using cpu_is_* on drivers.

    It is a common pattern in at91 drivers and has worked for ages.
    Do you think it is related to the need to be able to compile the
    driver for any SoC in the case of multi-SoC zImage support?

    Best regards,
    - --
    Nicolas Ferre
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.11 (GNU/Linux)
    Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

    iQEcBAEBAgAGBQJOuUd1AAoJEAf03oE53VmQs9UH/i+pKZlIN7lNb+sHvqHJhiUK
    zqvPObtSo2Y78dODM4Qf/WrJP/jBW4FUAx60kBlEBzWAD2aef1D078POAOVhcVdH
    Gj76Z+O5tF9H9YPcn/9HGyA42kL3NZu43ibywsvbUmX1O2LbtmX49bGOjArYSyXQ
    sN4F8+QJnkMQfmMNjYgG0WfhMyWnp15W4QWq+frk2Kq0nXjiuozqr9goq8/LVRZc
    aSToJUUJqsfk/bEGBAF6RmNxRIu2AMNpKQZS9a1gOZA/mAfSZrT9zQE6EZVXJDVr
    VVck4KlhHBR3JU6AEh0CtoRgfZxsZyzS2RNUDyF7dq+8VsNiNpajSL8S2ILanZc=
    =iqlm
    -----END PGP SIGNATURE-----


    \
     
     \ /
      Last update: 2011-11-08 16:19    [W:0.020 / U:31.572 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site