lkml.org 
[lkml]   [2011]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 6/9] perf: expose perf capability to other modules.
On Mon, Nov 07, 2011 at 03:07:50PM +0100, Peter Zijlstra wrote:
> On Thu, 2011-11-03 at 14:33 +0200, Gleb Natapov wrote:
> > @@ -1580,6 +1580,8 @@ __init int intel_pmu_init(void)
> > x86_pmu.num_counters = eax.split.num_counters;
> > x86_pmu.cntval_bits = eax.split.bit_width;
> > x86_pmu.cntval_mask = (1ULL << eax.split.bit_width) - 1;
> > + x86_pmu.events_mask = ebx;
> > + x86_pmu.events_mask_len = eax.split.mask_length;
> >
> > /*
> > * Quirk: v2 perfmon does not report fixed-purpose events, so
> > @@ -1651,6 +1653,7 @@ __init int intel_pmu_init(void)
> > * architectural event which is often completely bogus:
> > */
> > intel_perfmon_event_map[PERF_COUNT_HW_BRANCH_MISSES] = 0x7f89;
> > + x86_pmu.events_mask &= ~0x40;
> >
> > pr_cont("erratum AAJ80 worked around, ");
> > }
>
> It might make sense to introduce cpuid10_ebx or so, also I think the
cpuid10_ebx will have only one field though (event_mask).

> At the very least add a full ebx iteration to disable unsupported events
> in the intel-v1 case.
I do not understand what do you mean here, cpuid10_ebx was introduced by
intel v1 architectural PMU so it should already contain correct information.

--
Gleb.


\
 
 \ /
  Last update: 2011-11-08 13:51    [W:0.056 / U:5.144 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site