lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] Revert "leds: save the delay values after a successful call to blink_set()"
    Date
    This reverts commit 6123b0e274503a0d3588e84fbe07c9aa01bfaf5d.

    The problem this patch intends to solve has already been fixed by commit
    7a5caabd090b8f7 (drivers/leds/ledtrig-timer.c: fix broken sysfs delay
    handling).

    Signed-off-by: Johan Hovold <jhovold@gmail.com>
    ---

    Hi,

    A fix for the problem with the delay parameters not being stored is already in
    3.1 (and stable). Rather than storing both values at every call to
    led_blink_set only the updated value is stored in led_delay_{on,off}_store in
    ledtrig-timer.c.

    Thanks,
    Johan

    drivers/leds/led-class.c | 5 +----
    1 files changed, 1 insertions(+), 4 deletions(-)

    diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
    index 661b692..6d5628b 100644
    --- a/drivers/leds/led-class.c
    +++ b/drivers/leds/led-class.c
    @@ -270,11 +270,8 @@ void led_blink_set(struct led_classdev *led_cdev,
    del_timer_sync(&led_cdev->blink_timer);

    if (led_cdev->blink_set &&
    - !led_cdev->blink_set(led_cdev, delay_on, delay_off)) {
    - led_cdev->blink_delay_on = *delay_on;
    - led_cdev->blink_delay_off = *delay_off;
    + !led_cdev->blink_set(led_cdev, delay_on, delay_off))
    return;
    - }

    /* blink with 1 Hz as default if nothing specified */
    if (!*delay_on && !*delay_off)
    --
    1.7.6


    \
     
     \ /
      Last update: 2011-11-07 12:05    [W:0.022 / U:33.444 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site