lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 2/9] ACPI, APEI, Remove table not found message
    Date
    Because APEI tables are optional, these message may confuse users, for
    example,

    https://bugs.launchpad.net/ubuntu/+source/linux/+bug/599715

    Reported-by: Bjorn Helgaas <bhelgaas@google.com>
    Signed-off-by: Huang Ying <ying.huang@intel.com>
    ---
    drivers/acpi/apei/einj.c | 5 ++---
    drivers/acpi/apei/erst.c | 5 ++---
    drivers/acpi/apei/hest.c | 5 ++---
    3 files changed, 6 insertions(+), 9 deletions(-)

    --- a/drivers/acpi/apei/einj.c
    +++ b/drivers/acpi/apei/einj.c
    @@ -466,10 +466,9 @@ static int __init einj_init(void)

    status = acpi_get_table(ACPI_SIG_EINJ, 0,
    (struct acpi_table_header **)&einj_tab);
    - if (status == AE_NOT_FOUND) {
    - pr_info(EINJ_PFX "Table is not found!\n");
    + if (status == AE_NOT_FOUND)
    return -ENODEV;
    - } else if (ACPI_FAILURE(status)) {
    + else if (ACPI_FAILURE(status)) {
    const char *msg = acpi_format_exception(status);
    pr_err(EINJ_PFX "Failed to get table, %s\n", msg);
    return -EINVAL;
    --- a/drivers/acpi/apei/erst.c
    +++ b/drivers/acpi/apei/erst.c
    @@ -1112,10 +1112,9 @@ static int __init erst_init(void)

    status = acpi_get_table(ACPI_SIG_ERST, 0,
    (struct acpi_table_header **)&erst_tab);
    - if (status == AE_NOT_FOUND) {
    - pr_info(ERST_PFX "Table is not found!\n");
    + if (status == AE_NOT_FOUND)
    goto err;
    - } else if (ACPI_FAILURE(status)) {
    + else if (ACPI_FAILURE(status)) {
    const char *msg = acpi_format_exception(status);
    pr_err(ERST_PFX "Failed to get table, %s\n", msg);
    rc = -EINVAL;
    --- a/drivers/acpi/apei/hest.c
    +++ b/drivers/acpi/apei/hest.c
    @@ -221,10 +221,9 @@ void __init acpi_hest_init(void)

    status = acpi_get_table(ACPI_SIG_HEST, 0,
    (struct acpi_table_header **)&hest_tab);
    - if (status == AE_NOT_FOUND) {
    - pr_info(HEST_PFX "Table not found.\n");
    + if (status == AE_NOT_FOUND)
    goto err;
    - } else if (ACPI_FAILURE(status)) {
    + else if (ACPI_FAILURE(status)) {
    const char *msg = acpi_format_exception(status);
    pr_err(HEST_PFX "Failed to get table, %s\n", msg);
    rc = -EINVAL;

    \
     
     \ /
      Last update: 2011-11-08 03:43    [W:0.021 / U:1.148 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site