lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRE: [PATCH v3 0/8] Add support for tegra30 and cardhu
    Peter De Schrijver wrote at Monday, November 07, 2011 7:20 AM:
    > This patchset adds support for the tegra30 SoC and the cardhu development
    > board.
    >
    > Pathset is on top of Will Deacon's ARM reset work.

    A few minor issues:

    1) If I enable just ARCH_TEGRA_3x_SOC, but not ARCH_TEGRA_2x_SOC, the
    kernel fails to build because arch/arm/mach-tegra/include/mach/irqs.h
    only defines NR_IRQS if ARCH_TEGRA_2x_SOC is defined.

    2) All the Tegra20 boards don't depend on ARCH_TEGRA_2x_SOC, so they can
    be enabled even if only Tegra30 support is enabled.

    3) I notice that in "arm/tegra: pinmux tables and definitions for tegra30",
    you ifdef'd the two entries in tegra_pinmux_of_match[] based on which SoCs
    were enabled, but in "arm/tegra: implement support for tegra30", you didn't
    do the same for the two entries in early_init[] (board-dt.c). I'm not sure
    how far we want to take only-Tegra20 or only-Tegra30 support, but perhaps
    we should be consistent here?

    I've tested this series on Harmony both booting with a board file and booting
    using device-tree and don't see any issues. I'll try to test it on Cardhu
    later today.

    --
    nvpublic



    \
     
     \ /
      Last update: 2011-11-07 20:13    [W:0.031 / U:152.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site