lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] proc: restrict access to /proc/interrupts
/proc/interrupts contains the number of emitted interrupts, which
should not be world readable. The information about keyboard
interrupts number may be used to learn the precise number of characters in
users' passwords by simply watching the changes of number of emitted
interrupts during the life of gksu-like programs.

The PoC is publicly available at:

http://www.openwall.com/lists/oss-security/2011/11/07/9

Cc: <stable@kernel.org>
Signed-off-by: Vasiliy Kulikov <segoon@openwall.com>
---
fs/proc/interrupts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/proc/interrupts.c b/fs/proc/interrupts.c
index 05029c0..2fe87a1 100644
--- a/fs/proc/interrupts.c
+++ b/fs/proc/interrupts.c
@@ -47,7 +47,7 @@ static const struct file_operations proc_interrupts_operations = {

static int __init proc_interrupts_init(void)
{
- proc_create("interrupts", 0, NULL, &proc_interrupts_operations);
+ proc_create("interrupts", S_IRUSR, NULL, &proc_interrupts_operations);
return 0;
}
module_init(proc_interrupts_init);
--
1.7.0.4


\
 
 \ /
  Last update: 2011-11-07 18:49    [from the cache]
©2003-2011 Jasper Spaans