lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] hwmon: lm63: Add support for the NatSemi LM96163.
From
Date
Hi,

On Mon, 2011-11-07 at 05:20 -0500, Thierry Reding wrote:
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
> ---
> drivers/hwmon/lm63.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
> index 508cb29..94e373c 100644
> --- a/drivers/hwmon/lm63.c
> +++ b/drivers/hwmon/lm63.c
> @@ -483,7 +483,7 @@ static int lm63_detect(struct i2c_client *new_client,
> return -ENODEV;
> }
>
> - if (chip_id == 0x41 && address == 0x4c)
> + if ((chip_id == 0x41 || chip_id == 0x49) && address == 0x4c)
> strlcpy(info->type, "lm63", I2C_NAME_SIZE);
> else if (chip_id == 0x51 && (address == 0x18 || address == 0x4e))
> strlcpy(info->type, "lm64", I2C_NAME_SIZE);

Minor - the new chip should be mentioned in drivers/hwmon/Kconfig and in
Documentation/hwmon/lm63.

My main concern is that LM96163 supports a high resolution PWM mode.
Since that mode is much more convenient than the LM63-compatible mode, I
think it is likely to be enabled in designs using LM96163, and it should
be supported by the driver if we add support for LM96163.

Thanks,
Guenter




\
 
 \ /
  Last update: 2011-11-07 17:53    [from the cache]
©2003-2011 Jasper Spaans