lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] Input: convert obsolete strict_strtox to kstrtox
    Date
    Hi Dmitry,

    Thanks for the hint. I will send a new patch.

    Btw, there are still some simple_strtox uses floating around. Namely:

    drivers/input/joystick/analog.c:735: analog_options[i] = simple_strtoul(js[i], &end, 0);
    drivers/input/mouse/sentelic.c:415: reg = simple_strtoul(buf, &rest, 16);
    drivers/input/touchscreen/gunze.c:71: input_report_abs(dev, ABS_X, simple_strtoul(gunze->data + 1, NULL, 10));
    drivers/input/touchscreen/gunze.c:72: input_report_abs(dev, ABS_Y, 1024 - simple_strtoul(gunze->data + 6, NULL, 10));

    But I am not quite sure if it's safe to convert along the way. Is it OK
    to convert these?

    Thanks,
    jj

    On Sun, 6 Nov 2011 21:55:40 -0800, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
    > Hi JJ,
    >
    > On Mon, Nov 07, 2011 at 11:12:50AM +0800, JJ Ding wrote:
    > > From: JJ Ding <dgdunix@gmail.com>
    > >
    > > With commit 67d0a0754455f89ef3946946159d8ec9e45ce33a we mark strict_strtox
    > > as obsolete. Convert all remaining such uses in drivers/input/.
    >
    > Most of these users do not want long data, they just want an int, but
    > strict_strtouint was not available. Since we have kstrtouint now it
    > would be nice to use it.
    >
    > Thanks.
    >
    > --
    > Dmitry


    \
     
     \ /
      Last update: 2011-11-07 07:17    [W:0.021 / U:184.304 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site