lkml.org 
[lkml]   [2011]   [Nov]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 3/5] net/mac80211/debugfs.c: use kstrtoul, etc
    From
    On Sun, Nov 6, 2011 at 3:26 PM, Julia Lawall <julia@diku.dk> wrote:
    > From: Julia Lawall <julia@diku.dk>
    >
    > Use kstrtoul, etc instead of the now deprecated strict_strtoul, etc.
    >
    > A semantic patch rule for the kstrtoul case is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @@
    > expression a,b;
    > {int,long} *c;
    > @@
    >
    > -strict_strtoul
    > +kstrtoul
    >  (a,b,c)
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <julia@diku.dk>
    >
    > ---
    >  net/mac80211/debugfs.c |    2 +-
    >  1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff -u -p a/net/mac80211/debugfs.c b/net/mac80211/debugfs.c
    > --- a/net/mac80211/debugfs.c
    > +++ b/net/mac80211/debugfs.c
    > @@ -190,7 +190,7 @@ static ssize_t uapsd_max_sp_len_write(st
    >                return -EFAULT;
    >        buf[len] = '\0';
    >
    > -       ret = strict_strtoul(buf, 0, &val);
    > +       ret = kstrtoul(buf, 0, &val);
    >
    >        if (ret)
    >                return -EINVAL;
    >

    maybe while cleaning it up change copy_from_user +
    strict_stroul/kstroul -> kstroul_from_user?

    Eliad.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-11-07 12:49    [W:0.021 / U:1.952 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site