lkml.org 
[lkml]   [2011]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] dm-ioctl: Don't leak memory in target_message() if 'argc' is NULL
If 'argc' is NULL we'll jump to the 'out:' label, but this will leak
the memory that 'dm_split_args()' allocated for 'argv', so we should
be jumping to the 'out_argv:' label instead to free up that
memory. This patch does so.

Signed-off-by: Jesper Juhl <jj@chaosbits.net>
---
drivers/md/dm-ioctl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

note: compile tested only.

diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c
index 31c2dc2..1ce84ed 100644
--- a/drivers/md/dm-ioctl.c
+++ b/drivers/md/dm-ioctl.c
@@ -1437,7 +1437,7 @@ static int target_message(struct dm_ioctl *param, size_t param_size)

if (!argc) {
DMWARN("Empty message received.");
- goto out;
+ goto out_argv;
}

table = dm_get_live_table(md);
--
1.7.7.2

--
Jesper Juhl <jj@chaosbits.net> http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.



\
 
 \ /
  Last update: 2011-11-06 23:17    [W:0.026 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site