lkml.org 
[lkml]   [2011]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    Subjectwrite_cache_pages inefficiency
    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA1

    I've read over write_cache_pages() in page-writeback.c, and related
    writepages() functions, and it seems to me that it suffers from a
    performance problem whenever an fsync is done on a file and some of
    its pages have already begun writeback. The comment in the code says:

    * If a page is already under I/O, write_cache_pages() skips it, even
    * if it's dirty. This is desirable behaviour for memory-cleaning
    writeback,
    * but it is INCORRECT for data-integrity system calls such as
    fsync(). fsync()
    * and msync() need to guarantee that all the data which was dirty at
    the time
    * the call was made get new I/O started against them. If
    wbc->sync_mode is
    * WB_SYNC_ALL then we were called for data integrity and we must wait for
    * existing IO to complete.

    Based on this, I would expect the function to wait for an existing
    write to complete only if the page is also dirty. Instead, it waits
    for existing page writes to complete regardless of the dirty bit.
    Additionally, it does each wait serially, so if you are trying to
    fsync 1000 dirty pages, and the first 10 are already being written
    out, the thread will block on each of those 10 pages write completion
    before it begins queuing any new writes.

    Instead, shouldn't it go ahead and initiate pagewrite on all pages not
    already being written, and then come back and wait on those that were
    already in flight to complete, then initiate a second write on them if
    they are dirty?
    -----BEGIN PGP SIGNATURE-----
    Version: GnuPG v1.4.11 (GNU/Linux)
    Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

    iEYEARECAAYFAk63ALEACgkQJ4UciIs+XuL/NgCfXBftM2PRN10u0i3DBG94hny6
    dVoAoKbQp3yiY6ZotjbqHyd+kOEXiLgf
    =dK4Q
    -----END PGP SIGNATURE-----


    \
     
     \ /
      Last update: 2011-11-06 22:51    [W:0.019 / U:152.648 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site