lkml.org 
[lkml]   [2011]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] VME driver fixes
Date
Hi Martyn,

These three patches fix the issues raised by you in the discussion
regarding the removal of the VME driver from the staging tree.

* staging: vme: fix comment in __vme_register_driver()

This patch fixes the comment which doesn't apply as we didn't add the
bridge reference counting functions patch.

The code is still safe as vme_buses_lock is held when registering devices
(and vme_unregister_bridge needs to acquire it in order to remove the
bridge). The only different I can see is that the probe() calls will go
through entirely in this case before remove() is immediately called on
them (whereas with the vme_bridge_get(), a probe in the middle could fail
and we could quickly unregister the bridge).

* staging: vme: remove vme_add_bus() and vme_remove_bus()

These have been renamed to vme_register/unregister_bridge respectively.

Please let me know if you feel any other changes need to be made. Thanks
and best regards.

Manohar Vanga

Manohar Vanga (3):
staging: vme: fix comment in __vme_register_driver()
staging: vme: remove vme_add_bus() and vme_remove_bus()
staging: vme: fix comment for struct vme_dev

drivers/staging/vme/vme.c | 31 +++++++++----------------------
drivers/staging/vme/vme.h | 2 +-
2 files changed, 10 insertions(+), 23 deletions(-)

--
1.7.4.1



\
 
 \ /
  Last update: 2011-11-04 11:19    [W:0.043 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site