Messages in this thread | | | Date | Fri, 4 Nov 2011 09:32:22 +0000 | From | Ralf Baechle <> | Subject | Re: [PATCH RFC 4/8] mips: implement syscall restart generically |
| |
On Sun, Oct 23, 2011 at 12:19:58PM +0200, Jonas Bonn wrote:
> Manipulating task state to effect re-execution of an interrupted syscall > used to be purely architecture specific code. However, as most arch's > were essentially just making minor adjustments to almost identical logic, > this code could be moved to a common implementation. > > The generic variant introduces the function handle_syscall_restart() to be > called after get_signal_to_deliver(). The architecture specific register > manipulations required to effect the actual restart are now implemented > in the generic syscall interface found in asm/syscall.h > > This patch transitions this architecture's signal handling code over to > using the generic syscall restart code by: > > i) Implementing the register manipulations in asm/syscall.h > ii) Replacing the restart logic with a call to handle_syscall_restart
Nice cleanup.
Any reason why you add empty version of syscall_get_arguments and syscall_set_version? A non-functional version that causes a silent failure is way worse than something that fails at compile time.
Ralf
| |