lkml.org 
[lkml]   [2011]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] pm: remove useless array definition in cpuidle_structure
Date
Len, Arjan,

On Friday, November 04, 2011, Deepthi Dharwar wrote:
> On Friday 04 November 2011 03:14 AM, Robert Lee wrote:
> > From: Daniel Lezcano <daniel.lezcano@linaro.org>
> >
> > All the modules name are ro-data, it is never copied to the array.
> >
> > eg.
> >
> > static struct cpuidle_driver intel_idle_driver = {
> > .name = "intel_idle",
> > .owner = THIS_MODULE,
> > };
> >
> > It safe to assign the pointer of this ro-data to a const char *.
> > By this way we save 12 bytes.
> >
> > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Signed-off-by: Robert Lee <rob.lee@linaro.org>
> > ---
> > include/linux/cpuidle.h | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/cpuidle.h b/include/linux/cpuidle.h
> > index b51629e..16f9dce 100644
> > --- a/include/linux/cpuidle.h
> > +++ b/include/linux/cpuidle.h
> > @@ -117,8 +117,8 @@ static inline int cpuidle_get_last_residency(struct cpuidle_device *dev)
> > ****************************/
> >
> > struct cpuidle_driver {
> > - char name[CPUIDLE_NAME_LEN];
> > - struct module *owner;
> > + const char *name;
> > + struct module *owner;
> > };
> >
> > #ifdef CONFIG_CPU_IDLE
>
> This looks good, and makes it fool-proof by not allowing one to tamper the name of the driver.
> Tested OK on x86 (both Intel idle and ACPI)
>
> Tested-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>
> Reviewed-by: Deepthi Dharwar <deepthi@linux.vnet.ibm.com>

This is simple enough for me to push it for 3.2, but I woulnd't like to
step on anyone's toes. Please let me know what you think.

Rafael


\
 
 \ /
  Last update: 2011-11-04 23:29    [W:0.073 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site