Messages in this thread | | | From | "Mohammed, Afzal" <> | Subject | RE: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count | Date | Fri, 4 Nov 2011 16:32:43 +0000 |
| |
Hi Mark,
On Fri, Nov 04, 2011 at 21:48:56, Mark Brown wrote: > So that definitely seems wrong then - n_voltages is supposed to be the > number of voltages that can be selected so if the regulator supports > _NUM_VOLTS steps then I'd expect to see that constant used directly. > Otherwise I'd suggest that the magic number needs a #define. >
A gain of 0x1, 0x2, 0x3 is possible for each of the voltage steps, so we have a total of _NUM_VOLTS * 3 steps (although some of them would be same values).
Let me know your opinion on using _NUM_VOLTS * NUM_GAIN instead, with #define NUM_GAIN 3.
Regards Afzal
| |