lkml.org 
[lkml]   [2011]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] regulator:TPS65910: VDD1/2 voltage selector count
    On Fri, Nov 04, 2011 at 02:26:05PM +0000, Mohammed, Afzal wrote:
    > Hi Brown,

    Ahem.

    > On Fri, Nov 04, 2011 at 19:34:22, Mark Brown wrote:
    > > On Fri, Nov 04, 2011 at 06:18:48PM +0530, Afzal Mohammed wrote:

    > > > if (i == TPS65910_REG_VDD1 || i == TPS65910_REG_VDD2) {
    > > > pmic->desc[i].ops = &tps65910_ops_dcdc;
    > > > + pmic->desc[i].n_voltages = VDD1_2_NUM_VOLTS * 3;

    > > This looks suspicous - what's the * 3 about?

    > Gain in voltage possible is x1, 0x2 & 0x3, I am shaky
    > about this change, but voltage could be changed with this,

    That doesn't really clarify things - the question is why the number of
    voltages we can set is three times a constant called _NUM_VOLTS?


    \
     
     \ /
      Last update: 2011-11-04 16:29    [W:0.020 / U:20.328 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site