Messages in this thread | | | Date | Thu, 1 Dec 2011 01:53:42 +0100 | From | Alessandro Rubini <> | Subject | Re: [RGC PATCH 0/2] split file2alias using elf sections |
| |
Hello Rusty, thankyou for your feedback. I plan to make V2 tomorrow (it was planned much earlier).
> The table driven loop is nice and simple, though the E() macro is a bit > contrived.
Yes, but we have long names and I wanted to avoid splitting lines. I can make it ENTRY().
> The separation into separate files just to avoid merge issues is > overkill and useless churn. The conflicts are simple, and you've just > moved themto conflicts in the Makefile.
Yes and no. Actually, I expect several new buses to appear over time, and being separate files they can even be conditionally compiled based on config.
> We'd be better off putting the table in alphabetical order and stopping > there. Easy code, no tricks.
I see. I'm submitting two patches anyways, but you can pick one only.
Thanks /alessandro
| |