lkml.org 
[lkml]   [2011]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: build failure after merge of the final tree (akpm tree related)
On Tue, Nov 29, 2011 at 10:07:28PM -0800, Andrew Morton wrote:
> On Wed, 30 Nov 2011 00:40:10 -0500 (EST) David Miller <davem@davemloft.net> wrote:
>
> > From: Stephen Rothwell <sfr@canb.auug.org.au>
> > Date: Wed, 30 Nov 2011 15:52:26 +1100
> >
> > > And many more similar.
> > >
> > > Caused (or exposed) by commit 9222aa56c0ce
> > > ("include/net/netprio_cgroup.h: various fixes") from the akpm tree.
> > >
> > > I have reverted that commit for today.
> >
> > Andrew, please submit networking bug fixes to the networking maintainers
> > in order to avoid problems like this in the future.
> >
> > Unlike other subsystems, I guarentee to handle it within 24 hours, often
> > much faster.
> >
>
> This is my attempt to address the issues I mentioned last week. It is
> still under development and doesn't work yet. I thought it did.
>
> I'm now trying to get my brain around what that code is doing with
> Kconfig symbols and net_prio_subsys_id. I'm suspecting it's all to
> make cgroup-subsys-within-a-module appear to work.
>
> afaict net_prio_subsys_id is an enum if CONFIG_NETPRIO_CGROUP=y and is
> an `extern int' when CONFIG_NETPRIO_CGROUP=m. It's unclear to me why
> the extern int version or net_prio_subsys_id exists at all, really.
>
>
I implemented this code the same way that the net_cls cgroup does. I'm not at
all sure whats going on in your tree, as its building as both a module and
monolitically in net-next. I'll get it sorted today though.
Neil



\
 
 \ /
  Last update: 2011-11-30 12:51    [W:0.036 / U:1.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site