lkml.org 
[lkml]   [2011]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: WARNING: at kernel/lockdep.c:690 __lock_acquire+0x168/0x164b()
On (11/03/11 15:27), Yong Zhang wrote:
> > > A typcal race condition will like this:
> > >
> > > CPU A CPU B
> > > lock_set_subclass(lockA);
> > > lock_set_class(lockA);
> > > lockdep_init_map(lockA);
> > > /* lockA->name is cleared */
> > > memset(lockA);
> > > __lock_acquire(lockA);
> > > /* lockA->class_cache[] is cleared */
> > > register_lock_class(lockA);
> > > look_up_lock_class(lockA);
> > > WARN_ON_ONCE(class->name !=
> > > lock->name);
> > >
> > > lock->name = name;
> > >
> > > And a untested patch is below:
> > > BTW, now the patch could cure (I guess) the very issue reported
> > > in this thread.
> > > But it don't cover the case which change the key and the relevant
> > > lock_class has existed, I don't think out a way how to fix it yet :)
> > > But the fact is we have no such caller yet, the only call site of
> > > lock_set_subclass() is double_unlock_balance().
> > >
> >
> > Hello,
> > Any news on this patch? Do you like it or hate it? With recent kernels
> > I'm able to hit this problem more often (several time a day) so if any
> > testing is required I'm willing to help.
>
> Did you have tried it? Though I don't find time to polish it yet but
> I think will smooth your concern.
>

I'm compiling the kernel with you patch right now. The whole point was just for
case if someone has different approach or whatsoever.


Sergey


\
 
 \ /
  Last update: 2011-11-03 08:49    [W:0.084 / U:3.204 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site