lkml.org 
[lkml]   [2011]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: REGRESSION: "perf: Add PM notifiers ..." breaks resume
* Linus Torvalds <torvalds@linux-foundation.org> wrote:

> Peter, Ingo, ping?
>
> Quite frankly, I'm inclined to revert that patch just for being
> horribly ugly and apparently broken regardless of the fact that it
> also causes a regression.
>
> *Notifiers* for doing something like this? smp_call_function?
> That's just utter sh*t, guys.
>
> If it is CPU state, then it should damn well be suspended and
> resumed as part of CPU suspend and resume. No IPI cross-calls to
> ask other CPU's to do random work, no crap like that.

Agreed, that's quite crappy.

> Comments? Should I just revert the thing (silence is obviously
> "yes" in cases like this where we are talking about regressions
> anyway)?

Yep, please revert it until we do the right fix. (I can queue up the
revert too)

Thanks,

Ingo


\
 
 \ /
  Last update: 2011-11-03 08:41    [W:0.070 / U:0.152 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site