Messages in this thread | | | From | Mike Frysinger <> | Subject | Re: [PATCH 0/3] Change ARCH_NR_GPIO into a Kconfig variable | Date | Thu, 3 Nov 2011 18:16:33 -0400 |
| |
On Thursday 03 November 2011 13:00:44 Peter De Schrijver wrote: > This patchset converts ARCH_NR_GPIO to a Kconfig variable as suggested by > Russel King. It also converts some platforms to the new model. > > Peter De Schrijver (3): > ARM: ARCH_NR_GPIO: Make ARCH_NR_GPIO a Kconfig variable > ARM: mach-shmobile: Use CONFIG_ARCH_NR_GPIO > ARM: mach-ux500 Use CONFIG_ARCH_NR_GPIO > > arch/arm/Kconfig | 10 ++++++++++ > arch/arm/include/asm/gpio.h | 4 ++++ > arch/arm/mach-shmobile/include/mach/gpio.h | 2 -- > arch/arm/mach-ux500/include/mach/gpio.h | 5 ----- > 4 files changed, 14 insertions(+), 7 deletions(-)
i'm not sure how this is an improvement. we go from declaring the define in the right mach-specific subdir (arch/arm/mach-xxx/include/mach/gpio.h) to an arm-global file (arm/Kconfig). i'd think the ideal would be to keep all the mach cruft in the mach-xxx/ subdir. -mike [unhandled content-type:application/pgp-signature] | |