lkml.org 
[lkml]   [2011]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] clocksource: Avoid selecting mult values that might overflow when adjusted
From
Date
On Thu, 2011-11-03 at 13:05 +0100, Thomas Gleixner wrote:
> On Wed, 2 Nov 2011, John Stultz wrote:
> >
> > + WARN_ONCE(timekeeper.mult+adj >
> > + timekeeper.clock->mult + timekeeper.clock->maxadj,
> > + "Adjusting more then 11%%");
>
> Shouldn't we rather limit the update instead of just warn and overflow ?

Well, I'm hesitant to commit to that, just yet. So I figured I'd start
with the warning.

thanks
-john




\
 
 \ /
  Last update: 2011-11-03 14:13    [W:0.158 / U:24.416 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site