Messages in this thread | | | Date | Tue, 29 Nov 2011 10:45:43 +0100 | Subject | Re: [RFC PATCH 0/3] introduce: Multistate Switch Class | From | Linus Walleij <> |
| |
On Tue, Nov 29, 2011 at 10:11 AM, MyungJoo Ham <myungjoo.ham@gmail.com> wrote:
> For the next iteration, I'm considering the followings. It'd be much > appreciated if I could get some comments about those beforehand. > 1. ABI documentation
Good!
> 2. move the location from /drivers/misc to an independent location. > /drivers/switch? /drivers/multistate-switch? /drivers/msc? > /drivers/mswitch? ...
drivers/switch if I have my say. It looks intuitive.
> 3. Allow the notifiee device drivers to register its specific > interest. The interface would look like: > int switch_register_interest(struct switch_dev *sdev, const char > *cable_name, struct notifier_block *b); > (the rationale is that the notifiee device does not need to know the > detail about the switch dev configuration but for the name of the > switch dev or notifier). > or even > int switch_register_interest(const char *switch_name, const char > *cable_name, struct notifier_block *b); > and allow notifee to forget about the sdev pointer as well. (and all > the other APIs are for implementing notifier, not notifiee)
Good.
I will likely ack this once the code looks real nice, FWIW.
Yours, Linus Walleij
| |