[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH-RFC 1/2] tile: don't panic on iomap
    On Tue, Nov 29, 2011 at 10:54 AM, Michael S. Tsirkin <> wrote:
    > I think panic on iomap is there just for debugging.
    > If we return NULL instead, the generic pci_iomap will
    > DTRT so we don't need to roll our own.

    Just to be explicit about what "doing the right thing" means, here's
    what I think is changing (I think the new behavior is OK, but it *is*

    Old behavior: Caller calls pci_iomap(), which panics in ioport_map().

    New behavior: Caller calls pci_iomap(), ioport_map() returns NULL,
    pci_iomap() returns NULL (failure), caller may check for failure. If
    caller does not check for failure and passes the NULL to
    ioread()/iowrite(), we WARN in bad_io_access().

    >  static inline void __iomem *ioport_map(unsigned long port, unsigned int len)
    >  {
    > -       return (void __iomem *) ioport_panic();
    > +       pr_info("Trying to map an IO resource - it does not exit on tile.\n");
    > +       return NULL;


    Since we only expect to see this message during debugging, maybe it
    could be more informative, e.g., use dump_stack() to identify the
    offending driver? I don't think either the "Trying to map" message or
    the "Bad IO access" message is enough to actually make progress in

    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to
    More majordomo info at
    Please read the FAQ at

     \ /
      Last update: 2011-11-29 22:07    [W:0.024 / U:5.592 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site