lkml.org 
[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 12/25] perf symbols: Add nr_events to symbol_conf
Em Mon, Nov 28, 2011 at 09:44:38PM -0700, David Ahern escreveu:
> On 11/28/2011 04:14 PM, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@redhat.com>
> > Since symbol__alloc_hists need it, to avoid passing it around in many
> > functions have it in the symbol_conf struct.
>
> I get why you want to do this, but symbol_conf seems to be an odd
> choice. This is number of events, not how to resolve or display symbols.

Well, its related to something you do per-symbol, namely annotate how
many hits per ip per event it got in its addr range.

I plan at some point look again at the symbol system to check things
like this, the filter, the need to have a map to load things, but for
now I think we can leave it there.

- Arnaldo


\
 
 \ /
  Last update: 2011-11-29 12:55    [W:0.139 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site