lkml.org 
[lkml]   [2011]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] watchdog: fix nowayout setting in s3c2410_wdt
Hi Wolfram,

> > +/* Use the following function to set the nowayout feature */
> > +static inline void watchdog_set_nowayout(struct watchdog_device *wdd, int nowayout)
> > +{
> > + if (nowayout)
> > + set_bit(WDOG_NO_WAY_OUT, &wdd->status);
> > +}
>
> Yes, this is better in case we might need to add something later.
>
> > but: .status = WATCHDOG_NOWAYOUT_INIT_STATUS, is also a nice one to have.
> >
> > I propose to add both options and to document them in the documentation.
> > Objections anyone?
>
> Sounds good to me.
>
> So, I'll drop NOWAYOUT-related patches from my STMP-series?

Yes, I'll make sure we do the necessary on the nowayout side :-). Will try to add a patch for it today.
Could you resend the SMTP series after that you dropped the nowayout patches so I can review these?

Kind regards,
Wim.



\
 
 \ /
  Last update: 2011-11-29 11:51    [from the cache]
©2003-2011 Jasper Spaans