Messages in this thread | | | Date | Mon, 28 Nov 2011 18:08:07 -0500 (EST) | Subject | Re: [PATCH] net: Fix corruption in /proc/*/net/dev_mcast | From | David Miller <> |
| |
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Mon, 28 Nov 2011 10:55:16 +0100
>> With slub debugging on I see red zone issues in /proc/*/net/dev_mcast: >> >> ============================================================================= >> BUG kmalloc-8: Redzone overwritten >> ----------------------------------------------------------------------------- ... >> dev_mc_seq_ops uses dev_seq_start/next/stop but only allocates >> sizeof(struct seq_net_private) of private data, whereas it expects >> sizeof(struct dev_iter_state): >> >> struct dev_iter_state { >> struct seq_net_private p; >> unsigned int pos; /* bucket << BUCKET_SPACE + offset */ >> }; >> >> Create dev_seq_open_ops and use it so we don't have to expose >> struct dev_iter_state. >> >> Signed-off-by: Anton Blanchard <anton@samba.org> ... > Problem added by commit f04565ddf52e4 (dev: use name hash for > dev_seq_ops) > > > Acked-by: Eric Dumazet <eric.dumazet@gmail.com> > CC: Mihai Maruseac <mihai.maruseac@gmail.com>
Applied, thanks everyone.
| |