Messages in this thread | | | Subject | Re: [PATCH 10/11] wireless: Remove redundant spi driver bus initialization | From | Luciano Coelho <> | Date | Mon, 28 Nov 2011 09:20:07 +0200 |
| |
On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // <smpl> > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // </smpl> > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > Cc: Dan Williams <dcbw@redhat.com> > Cc: "John W. Linville" <linville@tuxdriver.com> > Cc: Christian Lamparter <chunkeey@googlemail.com> > Cc: Luciano Coelho <coelho@ti.com> > Cc: libertas-dev@lists.infradead.org > Cc: linux-wireless@vger.kernel.org > ---
[...]
> diff --git a/drivers/net/wireless/wl1251/spi.c b/drivers/net/wireless/wl1251/spi.c > index eaa5f95..6248c35 100644 > --- a/drivers/net/wireless/wl1251/spi.c > +++ b/drivers/net/wireless/wl1251/spi.c > @@ -319,7 +319,6 @@ static int __devexit wl1251_spi_remove(struct spi_device *spi) > static struct spi_driver wl1251_spi_driver = { > .driver = { > .name = DRIVER_NAME, > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > > diff --git a/drivers/net/wireless/wl12xx/spi.c b/drivers/net/wireless/wl12xx/spi.c > index 0f97186..12421a6 100644 > --- a/drivers/net/wireless/wl12xx/spi.c > +++ b/drivers/net/wireless/wl12xx/spi.c > @@ -462,7 +462,6 @@ static int __devexit wl1271_remove(struct spi_device *spi) > static struct spi_driver wl1271_spi_driver = { > .driver = { > .name = "wl1271_spi", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > },
For the wl12xx and wl1251 parts:
Acked-by: Luciano Coelho <coelho@ti.com>
-- Cheers, Luca.
| |