Messages in this thread | | | Subject | Re: [BUG] 3.2-rc2: BUG kmalloc-8: Redzone overwritten | From | Sasha Levin <> | Date | Sat, 26 Nov 2011 12:54:38 +0200 |
| |
On Mon, 2011-11-21 at 12:22 +0200, Sasha Levin wrote: > On Mon, 2011-11-21 at 11:21 +0100, Eric Dumazet wrote: > > Le lundi 21 novembre 2011 à 11:15 +0100, Eric Dumazet a écrit : > > > > > > > > Hmm, trinity tries to crash decnet ;) > > > > > > Maybe we should remove this decnet stuff for good instead of tracking > > > all bugs just for the record. Is there anybody still using decnet ? > > > > > > For example dn_start_slow_timer() starts a timer without holding a > > > reference on struct sock, this is highly suspect. > > > > > > [PATCH] decnet: proper socket refcounting > > > > > > Better use sk_reset_timer() / sk_stop_timer() helpers to make sure we > > > dont access already freed/reused memory later. > > > > > > Reported-by: Sasha Levin <levinsasha928@gmail.com> > > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > > > > Hmm, I forgot to remove the sock_hold(sk) call from dn_slow_timer(), > > here is V2 : > > > > [PATCH] decnet: proper socket refcounting > > > > Better use sk_reset_timer() / sk_stop_timer() helpers to make sure we > > dont access already freed/reused memory later. > > > > Reported-by: Sasha Levin <levinsasha928@gmail.com> > > Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> > > --- > > [snip] > > Applied locally and running same tests as before, will update with > results. >
Looks ok after a couple days of testing.
Tested-by: Sasha Levin <levinsasha928@gmail.com>
--
Sasha.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |