lkml.org 
[lkml]   [2011]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFC PATCH 3/7] drivers/zio: core files for the ZIO input/output
    Date
    In data sabato 26 novembre 2011 12:03:41, Greg KH ha scritto:
    > On Sat, Nov 26, 2011 at 06:30:42PM +0100, Alessandro Rubini wrote:
    > > +static struct kobj_type zdktype = { /* For standard and extended
    > > attribute */ + .release = NULL,
    >
    > Sweet!
    >
    > As-per the in-kernel documentation, I now get to mock you for doing
    > this :)
    >
    > Please NEVER DO THIS, you are ignoring the messages that the kernel
    > sends you when you remove one of these devices, and causing a memory
    > leak.

    Honestly we never see any messages about this.

    > Not nice at all, yet another reason to use a 'struct device'.

    I don't think is a valid reason, because device_release implementation require
    us to implement a release method within device, or device_type or class; so we
    can use kobj_type as well.

    > thanks,
    >
    > greg k-h
    --
    Federico Vaga


    \
     
     \ /
      Last update: 2011-11-26 23:59    [W:0.021 / U:29.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site