lkml.org 
[lkml]   [2011]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] usb: udc: Fix gadget driver's speed check in various UDC drivers
On Sat, Nov 19, 2011 at 06:26:25PM +0100, Michal Nazarewicz wrote:
> From: Michal Nazarewicz <mina86@mina86.com>
>
> Several UDC drivers had a gadget driver's speed sanity check of the
> form of:
>
> driver->speed != USB_SPEED_HIGH
>
> or:
>
> driver->speed != USB_SPEED_HIGH && driver->speed != USB_SPEED_FULL
>
> As more and more gadget drivers support USB SuperSpeed, driver->speed
> may be set to USB_SPEED_SUPER and UDC driver should handle such gadget
> correctly. The above checks however fail to recognise USB_SPEED_SUPER
> as a valid speed.
>
> This commit changes the two checks to:
>
> driver->speed < USB_SPEED_HIGH
>
> or:
>
> driver->speed < USB_SPEED_FULL
>
> respectively.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
> Reported-by: Alan Stern <stern@rowland.harvard.edu>

applied, thanks

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2011-11-24 10:49    [W:0.496 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site