Messages in this thread | | | Date | Thu, 24 Nov 2011 08:29:36 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [PATCH 3/5] SPI: Add helper macro for spi_driver boilerplate |
| |
On 11/24/2011 01:13 AM, Ben Dooks wrote: > On Wed, Nov 16, 2011 at 10:12:54AM -0700, Grant Likely wrote: >> On Wed, Nov 16, 2011 at 2:13 AM, Lars-Peter Clausen <lars@metafoo.de> wrote: >>> This patch introduces the module_spi_driver macro which is a convenience macro >>> for SPI driver modules similar to module_platform_driver. It is intended to be >>> used by drivers which init/exit section does nothing but register/unregister >>> the SPI driver. By using this macro it is possible to eliminate a few lines of >>> boilerplate code per SPI driver. >>> >>> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> >> >> Acked-by: Grant Likely <grant.likely@secretlab.ca> > > I'm begining to think we need to make some of these driver and device > bits more generic... there seems to be so much similar but not quite > the same code. >
I've been thinking the same. A good start would probably be consolidating the platform/spi/i2c device id handling code. Since those are all name based ids the code for handling them looks rather similar, though there are some minor differences.
- Lars
| |