lkml.org 
[lkml]   [2011]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ASoC: samsung: drop unknown Kconfig symbol
From
Date
On Thu, 2011-11-24 at 19:19 +0000, Mark Brown wrote:
> On Thu, Nov 24, 2011 at 08:09:14PM +0100, Paul Bolle wrote:
> > - Kconfig"), both dated May 14, 2007. So I'm touching code here that has
> > been unbuildable (in the mainline tree) for over four years. Isn't that
> > in itself sufficient to drop this code (and the incomplete kbuild stuff
> > supporting it)?
>
> No, not really. None of the OpenMoko code (including GTA02) has ever
> been usable in mainline as there's a reasonable patch stack for it out
> of tree and the more of their code is in mainline the more likely it is
> that that situation will improve.

A reasonable out of tree patch stack doesn't make the mainline tree
itself buildable. And it could be that having code in mainline makes it
more likely that this situation will improve. But, when I look at the
current situation of the mainline tree, I just see code that has been
unbuildable for over four years.

> The cost of extra platforms is really
> very low and people actually send me patches for the OpenMoko devices
> from time to time (much more frequently than for most other boards) so
> at least someone cares.

But - repeating my message - none of those patches made the code in the
mainline tree buildable.

I don't have any stake in the GTA01 code. So I don't really mind
deferring this discussion to (say) the end of the v3.3 merge period.
But, surely, there must be a point where one can conclude that
unbuildable code is just that?


Paul Bolle



\
 
 \ /
  Last update: 2011-11-24 21:01    [W:0.042 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site