lkml.org 
[lkml]   [2011]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 3.2-rc2 4/30] uprobes: Define hooks for mmap/munmap.
* Peter Zijlstra <peterz@infradead.org> [2011-11-23 19:10:12]:

> On Fri, 2011-11-18 at 16:37 +0530, Srikar Dronamraju wrote:
> > + ret = install_breakpoint(vma->vm_mm, uprobe);
> > + if (ret == -EEXIST) {
> > + atomic_inc(&vma->vm_mm->mm_uprobes_count);
> > + ret = 0;
> > + }
>
> Aren't you double counting that probe position here? The one that raced
> you to inserting it will also have incremented that counter, no?
>

No we arent.
Because register_uprobe can never race with mmap_uprobe and register
before mmap_uprobe registers .(Once we start mmap_region,
register_uprobe waits for the read_lock of mmap_sem.)

And we badly need this for mmap_uprobe case. Because when we do mremap,
or vma_adjust(), we do a munmap_uprobe() followed by mmap_uprobe() which
would have decremented the count but not removed it. So when we do a
mmap_uprobe, we need to increment the count.

--
Thanks and regards
Srikar



\
 
 \ /
  Last update: 2011-11-24 14:55    [W:0.113 / U:12.940 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site