lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 8/8] mm: memcg: modify PageCgroupCache non-atomically
On Wed, 23 Nov 2011 16:42:31 +0100
Johannes Weiner <hannes@cmpxchg.org> wrote:

> From: Johannes Weiner <jweiner@redhat.com>
>
> This bit is protected by lock_page_cgroup(), there is no need for
> locked operations when setting and clearing it.
>
> Signed-off-by: Johannes Weiner <jweiner@redhat.com>

Hm. non-atomic ops for pc->flags seems dangerous.
How about try to remove PCG_CACHE ? Maybe we can depends on PageAnon(page).
We see 'page' on memcg->lru now.
I'm sorry I forgot why we needed PCG_CACHE flag..

Thanks,
-Kame



\
 
 \ /
  Last update: 2011-11-24 01:17    [W:0.188 / U:7.308 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site