lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] dma/ep93xx_dma: prevent ep93xx_dma_tasklet() to access empty list
On Tue, Nov 22, 2011 at 02:26:52PM -0600, H Hartley Sweeten wrote:
>
> I still don't like the BUG_ON here. Is it even possible to get here with
> an empty list now that your catching it in the tasklet?

It's there just to make sure that we don't corrupt any memory if the list is
empty because of some other, yet unknown, bug.

>
> But, ep93xx_dma_set_active() also has a BUG_ON test so...
>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>

Thanks.


\
 
 \ /
  Last update: 2011-11-23 06:15    [W:0.247 / U:1.960 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site