Messages in this thread | | | Date | Wed, 23 Nov 2011 14:45:23 -0500 (EST) | From | Dave Anderson <> | Subject | Re: [RFC Patch 1/2][slimdump] Append CRASH_REASON to VMCOREINFO elf-note |
| |
----- Original Message ----- > On Mon, Nov 21, 2011 at 10:19:31AM -0500, Dave Anderson wrote: > > > > > > ----- Original Message ----- > > > Allow various crash paths to append the reason of crash into the > > > VMCOREINFO elf-note through the field CRASH_REASON. We also make the > > > fatal machine check exceptions append "PANIC_MCE" as the crash > > > reason. This string will be recognised by upstream tools like > > > makedumpfile and crash to generate slimdump. > > > > I don't understand -- how could "various paths" append a reason? > > The patch below seems to return "PANIC_MCE" for every x86 crash. > > What am I missing? > > > > Dave > > > > Yes, presently it can only be "PANIC_MCE" for MCE crashes in x86 (not > for every crash though).
Why only MCE crashes? If your arch/x86/kernel/cpu/mcheck/mce.c is compiled into any x86 kernel, then its arch_add_crash_reason() will always override the weak version in kernel/kexec.c, right?
Dave
| |