| Subject | Re: [PATCH v7 3.2-rc2 20/30] tracing: Extract out common code for kprobes/uprobes traceevents. | From | Steven Rostedt <> | Date | Wed, 23 Nov 2011 14:32:01 -0500 |
| |
On Fri, 2011-11-18 at 16:40 +0530, Srikar Dronamraju wrote: > --- /dev/null > +++ b/kernel/trace/trace_probe.h > @@ -0,0 +1,160 @@ > +/* > + * Common header file for probe-based Dynamic events. > + * > + * This program is free software; you can redistribute it and/or > modify > + * it under the terms of the GNU General Public License version 2 as > + * published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + * > + * You should have received a copy of the GNU General Public License > + * along with this program; if not, write to the Free Software > + * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA > 02111-1307 USA > + * > + * Copyright (C) IBM Corporation, 2010 > + * Author: Srikar Dronamraju > + * > + * Derived from kernel/trace/trace_kprobe.c written by
Shouldn't the above be:
include/linux/trace_kprobe.h ?
Although, I would think both of these files are a bit more that derived from. I would have been a bit stronger on the wording and say: This code was copied from trace_kprobe.[ch] written by Masami ...
Then say,
Updates to make this generic:
* Copyright (C) IBM Corporation, 2010 * Author: Srikar Dronamraju
-- Steve
> + * Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > + */ > +
|