lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] xHCI: Adding #define values used for hub descriptor
On Wed, Nov 23, 2011 at 10:20:10AM +0530, Aman Deep wrote:
> Hi Sarah,
>
>
> > >
> > > Also use some #defines in places where magic numbers are being used.
> >
> > Looks fine to me for the xHCI changes.  I copied most of the hub
> > descriptor code from EHCI, so it will need the same treatment.
>
> Okay, thanks. I will try to make some of these changes into other host
> controller drivers also as
> soon as I can.
>
> >
> > Acked-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
>
> Thanks for the ACK, Sarah.
>
> >
> > The #defines look a bit odd to me, like you're using spaces instead of
> > tabs to separate the name and value, or your mail program is converting
> > tabs to spaces.  Do the numbers line up for you?
>
> Actually, both the HUB_CHAR_TTTT and HUB_CHAR_PORTIND were already using
> spaces instead of tabs. I just copied them to the lines below, thats
> why they still have
> spaces between define and value.
>
> But thanks for info. I will take more care about this in future.
>
> Do you want me to make any changes in this patch ?

Fixing them up to have tabs instead of spaces would be nice, but is not
required. :)

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2011-11-23 18:03    [W:0.049 / U:1.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site