lkml.org 
[lkml]   [2011]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 5] PM: Update comments describing device power management callbacks
    On Wed, 23 Nov 2011, Rafael J. Wysocki wrote:

    > On Tuesday, November 22, 2011, Alan Stern wrote:
    > > On Tue, 22 Nov 2011, Rafael J. Wysocki wrote:
    > >
    > > > > The same data structure (dev_pm_ops) is used for both drivers and
    > > > > subsystems. Therefore the comments should be directed toward both
    > > > > driver writers and subsystem writers.
    > > >
    > > > I don't quite agree. Trying to do so would turn that comment into a lengthy
    > > > document and there's no room for anything like that in the header file.
    > >
    > > That's a good point.
    > >
    > > > Perhaps I'll just modify the comment to say when the callbacks are executed
    > > > without specifying what the specific callbacks are supposed to do (because
    > > > that may vary from one subsystem to another and even between different
    > > > drivers belonging to the same subsystem). If PM domains are taken into
    > > > account, it gets even more complicated.
    > >
    > > Yes, a minimal description would be good, along with a pointer to the
    > > Documentation/power files.
    >
    > Well, the one below is not exactly minimal, but I think it doesn't go too
    > far at least.

    Yes, I like this version better.

    Alan Stern



    \
     
     \ /
      Last update: 2011-11-23 17:31    [W:0.046 / U:270.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site