Messages in this thread | | | Date | Tue, 22 Nov 2011 10:28:36 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] regmap: Fix build failure with CONFIG_DEBUG_FS=n |
| |
On Tue, Nov 22, 2011 at 10:21:22AM +0100, Marc Kleine-Budde wrote: > On 11/22/2011 09:24 AM, Uwe Kleine-König wrote: > > This fixes: > > > > drivers/base/regmap/regcache-rbtree.c: In function 'regcache_rbtree_init': > > drivers/base/regmap/regcache-rbtree.c:197: error: 'struct regmap' has no member named 'debugfs' > > drivers/base/regmap/regcache-rbtree.c:197: error: 'rbtree_fops' undeclared (first use in this function) > > drivers/base/regmap/regcache-rbtree.c:197: error: (Each undeclared identifier is reported only once > > drivers/base/regmap/regcache-rbtree.c:197: error: for each function it appears in.) > > > > which was introduced by commit > > > > bad2ab4 (regmap: Provide debugfs dump of the rbtree cache data) > > > > currently in next-20111122. > > > > Cc: Mark Brown <broonie@opensource.wolfsonmicro.com> > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > --- > > drivers/base/regmap/regcache-rbtree.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/base/regmap/regcache-rbtree.c b/drivers/base/regmap/regcache-rbtree.c > > index 7767cbb..270ad65 100644 > > --- a/drivers/base/regmap/regcache-rbtree.c > > +++ b/drivers/base/regmap/regcache-rbtree.c > > @@ -194,7 +194,9 @@ static int regcache_rbtree_init(struct regmap *map) > > goto err; > > } > > > > +#ifdef CONFIG_DEBUG_FS > > debugfs_create_file("rbtree", 0400, map->debugfs, map, &rbtree_fops); > > +#endif > > What about introducing a debugfs_create_file() noop if debug-fs is not > compiled in? There is one, but that doesn't help map->debugfs or rbtree_fops being available. Ah, unless the debugfs_create_file stub would be a macro but currently it's a static inline.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |