lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[01/53] genirq: Fix irqfixup, irqpoll regression
    3.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Edward Donovan <edward.donovan@numble.net>

    commit c75d720fca8a91ce99196d33adea383621027bf2 upstream.

    commit d05c65fff0 ("genirq: spurious: Run only one poller at a time")
    introduced a regression, leaving the boot options 'irqfixup' and
    'irqpoll' non-functional. The patch placed tests in each function, to
    exit if the function is already running. The test in 'misrouted_irq'
    exited when it should have proceeded, effectively disabling
    'misrouted_irq' and 'poll_spurious_irqs'.

    The check for an already running poller needs to be "!= 1" not "== 1"
    as "1" is the value when the first poller starts running.

    Signed-off-by: Edward Donovan <edward.donovan@numble.net>
    Cc: maciej.rutecki@gmail.com
    Link: http://lkml.kernel.org/r/1320175784-6745-1-git-send-email-edward.donovan@numble.net
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    kernel/irq/spurious.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/kernel/irq/spurious.c
    +++ b/kernel/irq/spurious.c
    @@ -115,7 +115,7 @@ static int misrouted_irq(int irq)
    struct irq_desc *desc;
    int i, ok = 0;

    - if (atomic_inc_return(&irq_poll_active) == 1)
    + if (atomic_inc_return(&irq_poll_active) != 1)
    goto out;

    irq_poll_cpu = smp_processor_id();



    \
     
     \ /
      Last update: 2011-11-23 01:45    [W:0.020 / U:60.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site