Messages in this thread | | | Date | Tue, 22 Nov 2011 19:40:51 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets |
| |
On Tue, Nov 22, 2011 at 05:32:28PM +0000, Mark Brown wrote: > On Tue, Nov 22, 2011 at 06:05:48PM +0100, Marc Vertes wrote: > > > +static int wdt_start(struct watchdog_device *wdev) > > +{ > > + /* Nothing to do. The watchdog can only be started by the BIOS. */ > > + return 0; > > +} > > Shouldn't we just update the framework to cope with missing functions?
For start(), I dunno. I don't have enough experience with watchdog drivers to judge if this is acceptable, although I'd think so. For stop(), a few drivers already activate a timer to keep the watchdog happy; such a mechanism should definately go into the core. It's in my todo-list, but I won't be angry if someone is faster ;)
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |