Messages in this thread | | | From | "Hennerich, Michael" <> | Date | Tue, 22 Nov 2011 17:03:10 +0000 | Subject | RE: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching |
| |
Arnd Bergmann wrote on 2011-11-22: > On Friday 18 November 2011, michael.hennerich@analog.com wrote: >> From: Michael Hennerich <michael.hennerich@analog.com> >> >> Passing device name via platform data, is a leftover from times where >> SPI module device table matching was not existent. >> >> * Add id_table and remove old mechanism. >> (To my knowledge no intree boards affected) >> * Miscellaneous other cleanup. > > The patch looks good to me, but please don't do "miscelaneous other > cleanup" in the same patch. I think doing cleanups while you change a > driver is a good idea, just do the extra step to split those out into a > cleanup patch and describe what you do, just like you have split out the > bug fix. > > Arnd
Hi Arnd,
Thanks for reminding me. Will do in future.
Greetings, Michael
-- Analog Devices GmbH Wilhelm-Wagenfeld-Str. 6 80807 Muenchen Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368; Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin, Margaret Seif
| |