lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC][PATCH 0/3] fork: Add the ability to create tasks with given pids
    On Tue, Nov 22, 2011 at 07:23:12AM -0800, Tejun Heo wrote:
    > I think the question should usually be the other way around. Why
    > deviate when the deviation doesn't earn any tangible benefit? If you
    > think setting it explicitly is justified, explain why in the comment
    > of the setter and places where those explicit settings are.

    Hmmm... I think I trimmed a bit too much. Let me add back a bit.

    So, either just use set_last_pid() or explain in the comment of
    set_last_pid() that there are other places which set last_pid but it
    won't race because they're synchronized through outer lock and similar
    comment where the explicit setting of last_pid is too. As it
    currently stands, it really is difficult to find out who else would be
    changing last_pid - it's buried in an argument to a proc parse
    function. IMHO just using set_last_pid() would be better here.

    Thanks.

    --
    tejun


    \
     
     \ /
      Last update: 2011-11-22 16:31    [W:0.023 / U:1.112 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site