lkml.org 
[lkml]   [2011]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH V2 2/2] module: Fix performance regression on modules with large symbol tables
    Date
    On Thu, 17 Nov 2011 19:15:02 -0800, Kevin Cernekee <cernekee@gmail.com> wrote:
    > Potential memory savings from reusing EXACT strtab matches: 36,475 bytes
    > total; 35,432 from nvidia.ko. For comparison, discarding non-core
    > strtab entries saved about 91KB on my system.
    ...
    > Original scheme: 1.230s
    > With patch V2: 0.280s
    > With naive copying: 0.058s

    I'm deeply tempted. It's very simple, 46 lines shorter, preserves exact
    matches, and doesn't have any strange slowdowns on corner cases.

    But like Kevin, I could be convinced either way. Jan?

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2011-11-21 06:25    [W:0.018 / U:1.336 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site